From e6ad22924abfba5606ad7ccf88ec369fc9503587 Mon Sep 17 00:00:00 2001
From: Lewis Jones <ljones140@gmail.com>
Date: Wed, 9 Jul 2025 13:46:43 +0100
Subject: [PATCH] Refactor: improve full scan manifest test

---
 componentDetection.test.ts | 26 +++-----------------------
 1 file changed, 3 insertions(+), 23 deletions(-)

diff --git a/componentDetection.test.ts b/componentDetection.test.ts
index 3c0e7f5..fe28974 100644
--- a/componentDetection.test.ts
+++ b/componentDetection.test.ts
@@ -221,7 +221,6 @@ test('full action scan creates manifests with correct names and file source loca
   expect(manifests).toBeDefined();
   expect(manifests!.length).toBeGreaterThan(0);
 
-  // Ensure no manifest names have leading slashes
   for (const manifest of manifests!) {
     expect(manifest.name.startsWith('/')).toBe(false);
   }
@@ -234,34 +233,15 @@ test('full action scan creates manifests with correct names and file source loca
     'environment.yaml'
   ];
 
-  // Create a lookup for manifests by name
   const manifestsByName = manifests!.reduce((acc, manifest) => {
     acc[manifest.name] = manifest;
     return acc;
   }, {} as Record<string, any>);
 
-  // Check each expected manifest if it exists
   for (const expectedName of expectedManifestNames) {
     const manifest = manifestsByName[expectedName];
-    if (manifest) {
-      expect(manifest.name).toBe(expectedName);
-      expect(manifest.file?.source_location).toBe(expectedName);
-    }
-  }
-
-  // Verify specific expected manifests exist with correct properties
-  if (manifestsByName['package.json']) {
-    expect(manifestsByName['package.json'].name).toBe('package.json');
-    expect(manifestsByName['package.json'].file?.source_location).toBe('package.json');
-  }
-
-  if (manifestsByName['nested/package.json']) {
-    expect(manifestsByName['nested/package.json'].name).toBe('nested/package.json');
-    expect(manifestsByName['nested/package.json'].file?.source_location).toBe('nested/package.json');
-  }
-
-  if (manifestsByName['environment.yaml']) {
-    expect(manifestsByName['environment.yaml'].name).toBe('environment.yaml');
-    expect(manifestsByName['environment.yaml'].file?.source_location).toBe('environment.yaml');
+    expect(manifest).toBeDefined();
+    expect(manifest.name).toBe(expectedName);
+    expect(manifest.file?.source_location).toBe(expectedName);
   }
 }, 15000);