From 09100640b08783e39d3e403bd81de18b67839bcb Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Mon, 4 Jul 2022 11:06:05 +0900 Subject: [PATCH 1/3] Adjust types of node to 16.x again `npm uninstall @types/node && npm install --save-dev "@types/node@^16.11.43"` --- package-lock.json | 14 +++++++------- package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 82dddfa..08c0274 100644 --- a/package-lock.json +++ b/package-lock.json @@ -20,7 +20,7 @@ "zod": "^3.17.3" }, "devDependencies": { - "@types/node": "^18.0.0", + "@types/node": "^16.11.43", "@typescript-eslint/eslint-plugin": "^5.30.0", "@typescript-eslint/parser": "^5.30.0", "@vercel/ncc": "^0.34.0", @@ -1366,9 +1366,9 @@ } }, "node_modules/@types/node": { - "version": "18.0.0", - "resolved": "https://registry.npmjs.org/@types/node/-/node-18.0.0.tgz", - "integrity": "sha512-cHlGmko4gWLVI27cGJntjs/Sj8th9aYwplmZFwmmgYQQvL5NUsgVJG7OddLvNfLqYS31KFN0s3qlaD9qCaxACA==" + "version": "16.11.43", + "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.43.tgz", + "integrity": "sha512-GqWykok+3uocgfAJM8imbozrqLnPyTrpFlrryURQlw1EesPUCx5XxTiucWDSFF9/NUEXDuD4bnvHm8xfVGWTpQ==" }, "node_modules/@types/prettier": { "version": "2.4.4", @@ -8555,9 +8555,9 @@ } }, "@types/node": { - "version": "18.0.0", - "resolved": "https://registry.npmjs.org/@types/node/-/node-18.0.0.tgz", - "integrity": "sha512-cHlGmko4gWLVI27cGJntjs/Sj8th9aYwplmZFwmmgYQQvL5NUsgVJG7OddLvNfLqYS31KFN0s3qlaD9qCaxACA==" + "version": "16.11.43", + "resolved": "https://registry.npmjs.org/@types/node/-/node-16.11.43.tgz", + "integrity": "sha512-GqWykok+3uocgfAJM8imbozrqLnPyTrpFlrryURQlw1EesPUCx5XxTiucWDSFF9/NUEXDuD4bnvHm8xfVGWTpQ==" }, "@types/prettier": { "version": "2.4.4", diff --git a/package.json b/package.json index aa54d0f..476149a 100644 --- a/package.json +++ b/package.json @@ -36,7 +36,7 @@ "zod": "^3.17.3" }, "devDependencies": { - "@types/node": "^18.0.0", + "@types/node": "^16.11.43", "@typescript-eslint/eslint-plugin": "^5.30.0", "@typescript-eslint/parser": "^5.30.0", "@vercel/ncc": "^0.34.0", From 7f576504ed12e62b7177d31504f4cce15bce1164 Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Mon, 4 Jul 2022 11:21:13 +0900 Subject: [PATCH 2/3] Stop dependabot PRs for different major version of types It is possible to make a mismatch with actual logic. --- .github/dependabot.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index bb85b6f..1c104f3 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -9,3 +9,6 @@ updates: directory: / schedule: interval: daily + ignore: + - dependency-name: '@types/*' + update-types: ['version-update:semver-major'] From 51d1824002f10f80e63d23498751c3690b448db2 Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Wed, 6 Jul 2022 17:13:18 +0900 Subject: [PATCH 3/3] Focus only on the node issue https://github.com/actions/dependency-review-action/pull/141#discussion_r914526073 https://github.com/actions/dependency-review-action/pull/141#discussion_r914537222 Co-authored-by: Federico Builes --- .github/dependabot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 1c104f3..316a275 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -10,5 +10,5 @@ updates: schedule: interval: daily ignore: - - dependency-name: '@types/*' + - dependency-name: '@types/node' update-types: ['version-update:semver-major']