From bf0641d31237c28e27b9991b4a99511bd0226f62 Mon Sep 17 00:00:00 2001 From: Mike Coutermarsh Date: Thu, 15 Aug 2019 08:11:48 -0700 Subject: [PATCH 1/6] Fix typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b803c46..d27a627 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,3 @@ -# GitHub Actions service contianer examples +# GitHub Actions service container examples From ac54066131899e060dd32a1cabcbc2101f48671f Mon Sep 17 00:00:00 2001 From: Chris Patterson Date: Thu, 15 Aug 2019 12:49:47 -0400 Subject: [PATCH 2/6] Update postgres-service.yml --- .github/workflows/postgres-service.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/postgres-service.yml b/.github/workflows/postgres-service.yml index 8a23399..7160a41 100644 --- a/.github/workflows/postgres-service.yml +++ b/.github/workflows/postgres-service.yml @@ -15,6 +15,7 @@ jobs: POSTGRES_DB: postgres ports: - 5432:5432 + # needed because the postgres container does not provide a healthcheck options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5 redis: From 6c833c154de009c7a4724d484aacbd0b069d7f59 Mon Sep 17 00:00:00 2001 From: Chris Patterson Date: Thu, 15 Aug 2019 12:54:34 -0400 Subject: [PATCH 3/6] removing container property for this example --- .github/workflows/postgres-service.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/postgres-service.yml b/.github/workflows/postgres-service.yml index 7160a41..4f250b7 100644 --- a/.github/workflows/postgres-service.yml +++ b/.github/workflows/postgres-service.yml @@ -3,9 +3,7 @@ on: [push] jobs: build: runs-on: ubuntu-latest - container: - image: node:10.16-jessie - + services: postgres: image: postgres:10.8 From 844b2ca71ebed5bfad20c39589fc758a3a365628 Mon Sep 17 00:00:00 2001 From: Chris Patterson Date: Thu, 15 Aug 2019 12:59:17 -0400 Subject: [PATCH 4/6] Fixed typo in checkout --- .github/workflows/postgres-service.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/postgres-service.yml b/.github/workflows/postgres-service.yml index 4f250b7..9699620 100644 --- a/.github/workflows/postgres-service.yml +++ b/.github/workflows/postgres-service.yml @@ -22,6 +22,6 @@ jobs: - 6379:6379 steps: - - uses: actions/checkout@mv1 + - uses: actions/checkout@v1 - run: node client.js working-directory: ./postgres/ From 317582916f0dcaafa90a2a4be784d7e783656af2 Mon Sep 17 00:00:00 2001 From: Chris Patterson Date: Thu, 15 Aug 2019 13:00:56 -0400 Subject: [PATCH 5/6] adding npm install --- .github/workflows/postgres-service.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/postgres-service.yml b/.github/workflows/postgres-service.yml index 9699620..ca9390d 100644 --- a/.github/workflows/postgres-service.yml +++ b/.github/workflows/postgres-service.yml @@ -22,6 +22,8 @@ jobs: - 6379:6379 steps: - - uses: actions/checkout@v1 + - uses: actions/checkout@v1 + - run: npm install + working-directory: ./postgres - run: node client.js - working-directory: ./postgres/ + working-directory: ./postgres From c25014dbe55eb52e9f165df8bc63859b68ed2e8f Mon Sep 17 00:00:00 2001 From: Chris Patterson Date: Thu, 15 Aug 2019 13:03:03 -0400 Subject: [PATCH 6/6] Change to npm ci --- .github/workflows/postgres-service.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/postgres-service.yml b/.github/workflows/postgres-service.yml index ca9390d..691bde8 100644 --- a/.github/workflows/postgres-service.yml +++ b/.github/workflows/postgres-service.yml @@ -23,7 +23,7 @@ jobs: steps: - uses: actions/checkout@v1 - - run: npm install + - run: npm ci working-directory: ./postgres - run: node client.js working-directory: ./postgres