Files
gh-actions-cache/cmd/list_test.go

215 lines
6.5 KiB
Go
Raw Permalink Normal View History

package cmd
import (
Bugbash fixes and refactoring (#14) * Completed List cmd and added API calls * Minor comments and add delete code to pass linting * Typo in descriptions * Minor comments * Validations * Validations-1 * improved branch flag validation * removed build * working after refactory with bad names * Command working, test not working * Corrected creation of service * Finalized structure using service * Deleted tests * cleanup * cleanup * cleanup * removed space with tab * aligned types in model.go * Update model.go * resolved comments * Refactor * removed long descriptions * Working incomplete tests * Completed tests * cleanup * checks * PR comments * PR comments * minor comment issue * minor comment issue * Added test cases for Delete * updated tests to work with workflow * Added missing error condition * Updated tests to support new option service * Improved eror handling for list * Fixed test case * Improved error handling * Error handling and test cases for delete API calls * Added test case for user confirmation delete. * Removed unused import from test * Fixed test case for error scenario * Upgraded go-gh * reusing rest client error * Fix for failing windows test cases * help cmd removed when cache isnt present on delete * Pretty print ratio and space between cols modified * Error handling wrapping * Reverted back error message after silencing help * Bugbash fixes for int limit, zero cache list msg * Test case fixes for error message changes * Handling no cache list scenario with(out) key * Minor Refactoring and avoided code duplication * Removed unused inputs after resolving conflicts * Formatted test file * removed err5xx as they all have same value. * Removed err5xx from list as well * Help and error message enhancements for list. * changing commandname to avoid conflicts * Ran `go fmt` formatter against all .go files * Removed command from root.go * Updated version to 1.0.0 Co-authored-by: t-dedah <t-dedah@github.com> Co-authored-by: Deepak Dahiya <59823596+t-dedah@users.noreply.github.com>
2022-07-18 14:51:28 +05:30
"testing"
"github.com/actions/gh-actions-cache/internal"
"github.com/actions/gh-actions-cache/types"
Bugbash fixes and refactoring (#14) * Completed List cmd and added API calls * Minor comments and add delete code to pass linting * Typo in descriptions * Minor comments * Validations * Validations-1 * improved branch flag validation * removed build * working after refactory with bad names * Command working, test not working * Corrected creation of service * Finalized structure using service * Deleted tests * cleanup * cleanup * cleanup * removed space with tab * aligned types in model.go * Update model.go * resolved comments * Refactor * removed long descriptions * Working incomplete tests * Completed tests * cleanup * checks * PR comments * PR comments * minor comment issue * minor comment issue * Added test cases for Delete * updated tests to work with workflow * Added missing error condition * Updated tests to support new option service * Improved eror handling for list * Fixed test case * Improved error handling * Error handling and test cases for delete API calls * Added test case for user confirmation delete. * Removed unused import from test * Fixed test case for error scenario * Upgraded go-gh * reusing rest client error * Fix for failing windows test cases * help cmd removed when cache isnt present on delete * Pretty print ratio and space between cols modified * Error handling wrapping * Reverted back error message after silencing help * Bugbash fixes for int limit, zero cache list msg * Test case fixes for error message changes * Handling no cache list scenario with(out) key * Minor Refactoring and avoided code duplication * Removed unused inputs after resolving conflicts * Formatted test file * removed err5xx as they all have same value. * Removed err5xx from list as well * Help and error message enhancements for list. * changing commandname to avoid conflicts * Ran `go fmt` formatter against all .go files * Removed command from root.go * Updated version to 1.0.0 Co-authored-by: t-dedah <t-dedah@github.com> Co-authored-by: Deepak Dahiya <59823596+t-dedah@users.noreply.github.com>
2022-07-18 14:51:28 +05:30
"github.com/stretchr/testify/assert"
"gopkg.in/h2non/gock.v1"
)
func TestListWithIncorrectArguments(t *testing.T) {
t.Cleanup(gock.Off)
cmd := NewCmdList()
cmd.SetArgs([]string{"keyValue"})
err := cmd.Execute()
assert.ErrorContains(t, err, "Invalid argument(s). Expected 0 received 1")
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}
func TestListWithIncorrectRepo(t *testing.T) {
t.Cleanup(gock.Off)
cmd := NewCmdList()
cmd.SetArgs([]string{"--repo", "testOrg/testRepo/123/123"})
err := cmd.Execute()
assert.ErrorContains(t, err, "expected the \"[HOST/]OWNER/REPO\" format, got \"testOrg/testRepo/123/123\"")
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}
func TestListWithNegativeLimit(t *testing.T) {
t.Cleanup(gock.Off)
cmd := NewCmdList()
cmd.SetArgs([]string{"--limit", "-1", "--repo", "testOrg/testRepo"})
err := cmd.Execute()
assert.ErrorContains(t, err, "-1 is not a valid integer value for limit flag. Allowed values: 1-100")
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}
func TestListWithIncorrectLimit(t *testing.T) {
t.Cleanup(gock.Off)
cmd := NewCmdList()
cmd.SetArgs([]string{"--limit", "101", "--repo", "testOrg/testRepo"})
err := cmd.Execute()
assert.ErrorContains(t, err, "101 is not a valid integer value for limit flag. Allowed values: 1-100")
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}
func TestListLimitShorthandUsingIncorrectLimit(t *testing.T) {
t.Cleanup(gock.Off)
cmd := NewCmdList()
cmd.SetArgs([]string{"-L", "102", "--repo", "testOrg/testRepo"})
err := cmd.Execute()
assert.ErrorContains(t, err, "102 is not a valid integer value for limit flag. Allowed values: 1-100")
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}
func TestListWithIncorrectOrder(t *testing.T) {
t.Cleanup(gock.Off)
cmd := NewCmdList()
cmd.SetArgs([]string{"--order", "incorrectOrderValue", "--repo", "testOrg/testRepo"})
err := cmd.Execute()
assert.ErrorContains(t, err, "incorrectOrderValue is not a valid value for order flag. Allowed values: asc/desc")
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}
func TestListWithIncorrectSort(t *testing.T) {
t.Cleanup(gock.Off)
cmd := NewCmdList()
cmd.SetArgs([]string{"--sort", "incorrectSortValue", "--repo", "testOrg/testRepo"})
err := cmd.Execute()
assert.ErrorContains(t, err, "incorrectSortValue is not a valid value for sort flag. Allowed values: last-used/size/created-at")
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}
func TestListWithIncorrectRepoForListCaches(t *testing.T) {
t.Cleanup(gock.Off)
gock.New("https://api.github.com").
Get("/repos/testOrg/testRepo/actions/cache/usage").
Reply(200).
JSON(`{
"full_name": "t-dedah/vipul-bugbash",
"active_caches_size_in_bytes": 291205,
"active_caches_count": 12
}`)
gock.New("https://api.github.com").
Get("/repos/testOrg/testRepo/actions/caches").
Reply(404).
JSON(`{
"message": "Not Found",
"documentation_url": "https://docs.github.com/rest/reference/actions#get-github-actions-cache-list-for-a-repository"
}`)
cmd := NewCmdList()
cmd.SetArgs([]string{"--repo", "testOrg/testRepo"})
err := cmd.Execute()
var customError types.HandledError
if assert.ErrorAs(t, err, &customError) {
assert.Equal(t, "The given repo does not exist.", customError.Message)
}
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}
func TestListWithUnauthorizedRequestForListCaches(t *testing.T) {
t.Cleanup(gock.Off)
gock.New("https://api.github.com").
Get("/repos/testOrg/testRepo/actions/cache/usage").
Reply(200).
JSON(`{
"full_name": "t-dedah/vipul-bugbash",
"active_caches_size_in_bytes": 291205,
"active_caches_count": 12
}`)
gock.New("https://api.github.com").
Get("/repos/testOrg/testRepo/actions/caches").
Reply(401).
JSON(`{
"message": "Must have admin rights to Repository.",
"documentation_url": "https://docs.github.com/rest/actions/cache#delete-a-github-actions-cache-for-a-repository-using-a-cache-id"
}`)
cmd := NewCmdList()
cmd.SetArgs([]string{"--repo", "testOrg/testRepo"})
err := cmd.Execute()
var customError types.HandledError
if assert.ErrorAs(t, err, &customError) {
assert.Equal(t, "Must have admin rights to Repository.", customError.Message)
}
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}
func TestListWithInternalServerErrorForListCaches(t *testing.T) {
t.Cleanup(gock.Off)
gock.New("https://api.github.com").
Get("/repos/testOrg/testRepo/actions/cache/usage").
Reply(200).
JSON(`{
"full_name": "t-dedah/vipul-bugbash",
"active_caches_size_in_bytes": 291205,
"active_caches_count": 12
}`)
gock.New("https://api.github.com").
Get("/repos/testOrg/testRepo/actions/caches").
Reply(500).
JSON(`{
"message": "Internal Server Error",
"documentation_url": "https://docs.github.com/rest/reference/actions#get-github-actions-cache-list-for-a-repository"
}`)
cmd := NewCmdList()
cmd.SetArgs([]string{"--repo", "testOrg/testRepo"})
err := cmd.Execute()
var customError types.HandledError
if assert.ErrorAs(t, err, &customError) {
assert.Equal(t, "We could not process your request due to internal error.", customError.Message)
}
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}
func TestListSuccess(t *testing.T) {
t.Cleanup(gock.Off)
gock.New("https://api.github.com").
Get("/repos/testOrg/testRepo/actions/cache/usage").
Reply(200).
JSON(`{
"full_name": "t-dedah/vipul-bugbash",
"active_caches_size_in_bytes": 2432967,
"active_caches_count": 1
}`)
gock.New("https://api.github.com").
Get("/repos/testOrg/testRepo/actions/caches").
Reply(200).
JSON(`{
"total_count": 1,
"actions_caches": [
{
"id": 29,
"ref": "refs/heads/master",
"key": "Linux-build-cache-node-modules-3fd22dd3a926d576e2562e8b76a5ff157cd3b986f3d44195acfe7efa6bc05919-8",
"version": "7fcda33c1e1d849a13bcc06f49b9ab64efc01ca9dabe4d7a8d0d387feef4fc88",
"last_accessed_at": "2022-06-22T20:32:45.550000000Z",
"created_at": "2022-06-22T20:32:45.550000000Z",
"size_in_bytes": 2432967
}]
}`)
cmd := NewCmdList()
cmd.SetArgs([]string{"--repo", "testOrg/testRepo"})
err := cmd.Execute()
assert.NoError(t, err)
assert.True(t, gock.IsDone(), internal.PrintPendingMocks(gock.Pending()))
}