Tests for CLI (#6)

* Completed List cmd and added API calls

* Minor comments and add delete code to pass linting

* Typo in descriptions

* Minor comments

* Validations

* Validations-1

* improved branch flag validation

* removed build

* working after refactory with bad names

* Command working, test not working

* Corrected creation of service

* Finalized structure using service

* Deleted tests

* cleanup

* cleanup

* cleanup

* removed space with tab

* aligned types in model.go

* Update model.go

* resolved comments

* Refactor

* removed long descriptions

* Working incomplete tests

* Completed tests

* cleanup

* checks

* PR comments

* PR comments

* minor comment issue

* minor comment issue

* updated tests to work with workflow

* Updated tests to support new option service

* Improved eror handling for list

* Improved error handling

* Upgraded go-gh

* reusing rest client error

cmd/delete.go

@@ -17,31 +17,38 @@ func NewCmdDelete() *cobra.Command {
 	f := types.DeleteOptions{}
 
 	var deleteCmd = &cobra.Command{
-		Use:   "delete",
+		Use:   "delete <key>",
 		Short: "Delete cache by key",
-		Run: func(cmd *cobra.Command, args []string) {
+		RunE: func(cmd *cobra.Command, args []string) error {
 			if len(args) != 1 {
-				fmt.Printf("accepts 1 arg(s), received %d\n", len(args))
-				return
+				return fmt.Errorf(fmt.Sprintf("accepts 1 arg(s), received %d", len(args)))
 			}
 
 			f.Key = args[0]
 
 			repo, err := internal.GetRepo(f.Repo)
 			if err != nil {
-				fmt.Println(err)
-				return
+				return err
 			}
-			artifactCache := service.NewArtifactCache(repo, COMMAND, VERSION)
+
+			artifactCache, err := service.NewArtifactCache(repo, COMMAND, VERSION)
+			if err != nil {
+				fmt.Printf("error connecting to %s\n", repo.Host())
+				fmt.Println("check your internet connection or https://githubstatus.com")
+				return nil
+			}
+
 			queryParams := url.Values{}
 			f.GenerateBaseQueryParams(queryParams)
 
 			if !f.Confirm {
-				var matchedCaches = getCacheListWithExactMatch(f, artifactCache)
+				matchedCaches, err := getCacheListWithExactMatch(f, artifactCache)
+				if err != nil {
+					return err
+				}
 				matchedCachesLen := len(matchedCaches)
 				if matchedCachesLen == 0 {
-					fmt.Printf("Cache with input key '%s' does not exist\n", f.Key)
-					return
+					return fmt.Errorf(fmt.Sprintf("Cache with input key '%s' does not exist\n", f.Key))
 				}
 				fmt.Printf("You're going to delete %s", internal.PrintSingularOrPlural(matchedCachesLen, "cache entry\n\n", "cache entries\n\n"))
 				internal.PrettyPrintTrimmedCacheList(matchedCaches)
@@ -50,22 +57,26 @@ func NewCmdDelete() *cobra.Command {
 					Message: "Are you sure you want to delete the cache entries?",
 					Options: []string{"Delete", "Cancel"},
 				}
-				err := survey.AskOne(prompt, &choice)
+				err = survey.AskOne(prompt, &choice)
 				if err != nil {
-					fmt.Println("Error occured while taking input from user while trying to delete cache")
-					return
+					return fmt.Errorf("Error occured while taking input from user while trying to delete cache")
 				}
 				f.Confirm = choice == "Delete"
 				fmt.Println()
 			}
 			if f.Confirm {
-				cachesDeleted := artifactCache.DeleteCaches(queryParams)
+				cachesDeleted, err := artifactCache.DeleteCaches(queryParams)
+				if err != nil {
+					return err
+				}
+
 				if cachesDeleted > 0 {
 					fmt.Printf("%s Deleted %s with key '%s'\n", internal.RedTick(), internal.PrintSingularOrPlural(cachesDeleted, "cache entry", "cache entries"), f.Key)
 				} else {
 					fmt.Printf("Cache with input key '%s' does not exist\n", f.Key)
 				}
 			}
+			return nil
 		},
 	}
 	deleteCmd.Flags().StringVarP(&f.Repo, "repo", "R", "", "Select another repository for finding actions cache.")
@@ -99,18 +110,20 @@ EXAMPLES:
 `
 }
 
-func getCacheListWithExactMatch(f types.DeleteOptions, artifactCache service.ArtifactCacheService) []types.ActionsCache {
+func getCacheListWithExactMatch(f types.DeleteOptions, artifactCache service.ArtifactCacheService) ([]types.ActionsCache, error) {
 	listOption := types.ListOptions{BaseOptions: types.BaseOptions{Repo: f.Repo, Branch: f.Branch, Key: f.Key}, Limit: 100, Order: "", Sort: ""}
 	queryParams := url.Values{}
 
 	listOption.GenerateBaseQueryParams(queryParams)
-	caches := artifactCache.ListAllCaches(queryParams, f.Key)
-
+	caches, err := artifactCache.ListAllCaches(queryParams, f.Key)
+	if err != nil {
+		return nil, err
+	}
 	var exactMatchedKeys []types.ActionsCache
 	for _, cache := range caches {
 		if strings.EqualFold(f.Key, cache.Key) {
 			exactMatchedKeys = append(exactMatchedKeys, cache)
 		}
 	}
-	return exactMatchedKeys
+	return exactMatchedKeys, nil
 }