docker/actions-toolkit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

github: handle malformed runtime token

Browse Source 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
This commit is contained in:
CrazyMax
2023-02-03 04:37:26 +01:00
parent 3e2548a8ed
commit 7a9a28cd90
2 changed files with 28 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
__tests__/github.test.ts
View File

@@ -102,7 +102,13 @@ describe('actionsRuntimeToken', () => {
}); });
it('empty', async () => { it('empty', async () => {
process.env.ACTIONS_RUNTIME_TOKEN = ''; process.env.ACTIONS_RUNTIME_TOKEN = '';
expect(GitHub.actionsRuntimeToken).toEqual({}); expect(GitHub.actionsRuntimeToken).toBeUndefined();
});
it('malformed', async () => {
process.env.ACTIONS_RUNTIME_TOKEN = 'foo';
expect(() => {
GitHub.actionsRuntimeToken;
}).toThrowError();
}); });
it('fixture', async () => { it('fixture', async () => {
process.env.ACTIONS_RUNTIME_TOKEN = fs.readFileSync(path.join(__dirname, 'fixtures', 'runtimeToken.txt')).toString().trim(); process.env.ACTIONS_RUNTIME_TOKEN = fs.readFileSync(path.join(__dirname, 'fixtures', 'runtimeToken.txt')).toString().trim();
@@ -124,15 +130,24 @@ describe('printActionsRuntimeTokenACs', () => {
process.env = originalEnv; process.env = originalEnv;
}); });
it('empty', async () => { it('empty', async () => {
const execSpy = jest.spyOn(core, 'info'); const warnSpy = jest.spyOn(core, 'warning');
process.env.ACTIONS_RUNTIME_TOKEN = ''; process.env.ACTIONS_RUNTIME_TOKEN = '';
await GitHub.printActionsRuntimeTokenACs(); await GitHub.printActionsRuntimeTokenACs();
expect(execSpy).toHaveBeenCalledWith(`ACTIONS_RUNTIME_TOKEN not set`); expect(warnSpy).toHaveBeenCalledTimes(1);
expect(warnSpy).toHaveBeenCalledWith(`ACTIONS_RUNTIME_TOKEN not set`);
});
it('malformed', async () => {
const warnSpy = jest.spyOn(core, 'warning');
process.env.ACTIONS_RUNTIME_TOKEN = 'foo';
await GitHub.printActionsRuntimeTokenACs();
expect(warnSpy).toHaveBeenCalledTimes(1);
expect(warnSpy).toHaveBeenCalledWith(`Cannot parse Actions Runtime Token: Invalid token specified: Cannot read properties of undefined (reading 'replace')`);
}); });
it('refs/heads/master', async () => { it('refs/heads/master', async () => {
const execSpy = jest.spyOn(core, 'info'); const infoSpy = jest.spyOn(core, 'info');
process.env.ACTIONS_RUNTIME_TOKEN = fs.readFileSync(path.join(__dirname, 'fixtures', 'runtimeToken.txt')).toString().trim(); process.env.ACTIONS_RUNTIME_TOKEN = fs.readFileSync(path.join(__dirname, 'fixtures', 'runtimeToken.txt')).toString().trim();
await GitHub.printActionsRuntimeTokenACs(); await GitHub.printActionsRuntimeTokenACs();
expect(execSpy).toHaveBeenCalledWith(`refs/heads/master: read/write`); expect(infoSpy).toHaveBeenCalledTimes(1);
expect(infoSpy).toHaveBeenCalledWith(`refs/heads/master: read/write`);
}); });
}); });

10
src/github.ts
View File

@@ -55,9 +55,15 @@ export class GitHub {
} }
public static async printActionsRuntimeTokenACs() { public static async printActionsRuntimeTokenACs() {
const jwt = GitHub.actionsRuntimeToken; let jwt: GitHubActionsRuntimeToken | undefined;
try {
jwt = GitHub.actionsRuntimeToken;
} catch (e) {
core.warning(`Cannot parse Actions Runtime Token: ${e.message}`);
return;
}
if (!jwt) { if (!jwt) {
core.info(`ACTIONS_RUNTIME_TOKEN not set`); core.warning(`ACTIONS_RUNTIME_TOKEN not set`);
return; return;
} }
try { try {