From f9195a21339523a8df3cb6aa5ee018e22572c7c2 Mon Sep 17 00:00:00 2001 From: Jonny Stoten Date: Tue, 11 Jun 2024 11:29:09 +0100 Subject: [PATCH] Don't exit on failure to write OK to panic on marshal error as this would be a developer error --- pkg/utils/utils.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/utils/utils.go b/pkg/utils/utils.go index f97a42b..b87218d 100644 --- a/pkg/utils/utils.go +++ b/pkg/utils/utils.go @@ -3,7 +3,6 @@ package utils import ( "encoding/json" "net/http" - "os" "github.com/open-policy-agent/frameworks/constraint/pkg/externaldata" "k8s.io/klog/v2" @@ -35,13 +34,13 @@ func SendResponse(results *[]externaldata.Item, systemErr string, w http.Respons body, err := json.Marshal(response) if err != nil { klog.ErrorS(err, "unable to marshal response") - os.Exit(1) + panic(err) } w.Header().Set("Content-Type", "application/json") _, err = w.Write(body) if err != nil { klog.ErrorS(err, "unable to write response") - os.Exit(1) + return } }