docker/attest-provider
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #53 from docker/fix-crash-loop

Browse Source 
Don't error if TUF client can't initialize on boot
This commit is contained in:
Joel Kamp
2024-07-26 11:01:03 -05:00
committed by GitHub
parent 4591f2f6db 6522d3551f
commit f9c2214bbc
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
pkg/handler/validate.go
View File

@@ -50,7 +50,10 @@ func NewValidateHandler(opts *ValidateHandlerOptions) (http.Handler, error) {
// TODO: this pre-loading works for the root, targets, snapshot, and timestamp roles, but not for delegated roles. // TODO: this pre-loading works for the root, targets, snapshot, and timestamp roles, but not for delegated roles.
_, err := handler.createTUFClient() _, err := handler.createTUFClient()
if err != nil { if err != nil {
return nil, err // if this failed, don't return an error, just log it and continue
// this prevents the server from getting into a crash loop if the TUF repo is down or broken,
// and we can still recover if the TUF repo comes back up.
klog.ErrorS(err, "failed to initialize TUF client")
} }
klog.Infof("validate handler initialized with %s TUF root", opts.TUFRoot) klog.Infof("validate handler initialized with %s TUF root", opts.TUFRoot)