Use assert.NoError for nil checks on errors

pkg/mirror/metadata_test.go

@@ -21,10 +21,10 @@ func TestGetTufMetadataMirror(t *testing.T) {
 
 	path := test.CreateTempDir(t, "", "tuf_temp")
 	m, err := NewTufMirror(embed.DevRoot, path, server.URL+"/metadata", server.URL+"/targets")
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 
 	tufMetadata, err := m.getTufMetadataMirror(server.URL + "/metadata")
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 
 	// check that all roles are not empty
 	assert.Greater(t, len(tufMetadata.Root), 0)
@@ -39,15 +39,15 @@ func TestGetMetadataManifest(t *testing.T) {
 
 	path := test.CreateTempDir(t, "", "tuf_temp")
 	m, err := NewTufMirror(embed.DevRoot, path, server.URL+"/metadata", server.URL+"/targets")
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 
 	img, err := m.GetMetadataManifest(server.URL + "/metadata")
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.NotNil(t, img)
 
 	image := *img
 	mf, err := image.RawManifest()
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 
 	type Annotations struct {
 		Annotations map[string]string `json:"annotations"`
@@ -57,7 +57,7 @@ func TestGetMetadataManifest(t *testing.T) {
 	}
 	l := &Layers{}
 	err = json.Unmarshal(mf, l)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 
 	// check that layers are annotated and use consistent snapshot naming
 	for _, layer := range l.Layers {
@@ -69,7 +69,7 @@ func TestGetMetadataManifest(t *testing.T) {
 			continue
 		}
 		_, err := strconv.Atoi(parts[0])
-		assert.Nil(t, err)
+		assert.NoError(t, err)
 	}
 }
 
@@ -79,10 +79,10 @@ func TestGetDelegatedMetadataMirrors(t *testing.T) {
 
 	path := test.CreateTempDir(t, "", "tuf_temp")
 	m, err := NewTufMirror(embed.DevRoot, path, server.URL+"/metadata", server.URL+"/targets")
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 
 	delegations, err := m.GetDelegatedMetadataMirrors()
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 
 	assert.NotNil(t, delegations)
 	assert.Greater(t, len(delegations), 0)

pkg/mirror/targets_test.go

@@ -27,22 +27,22 @@ func TestGetTufTargetsMirror(t *testing.T) {
 
 	path := test.CreateTempDir(t, "", "tuf_temp")
 	m, err := NewTufMirror(embed.DevRoot, path, server.URL+"/metadata", server.URL+"/targets")
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 
 	targets, err := m.GetTufTargetMirrors()
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.Greater(t, len(targets), 0)
 
 	// check for image layer annotations
 	for _, target := range targets {
 		img := *target.Image
 		mf, err := img.RawManifest()
-		assert.Nil(t, err)
+		assert.NoError(t, err)
 
 		// unmarshal manifest with annotations
 		l := &Layers{}
 		err = json.Unmarshal(mf, l)
-		assert.Nil(t, err)
+		assert.NoError(t, err)
 
 		// check that layers are annotated
 		for _, layer := range l.Layers {
@@ -61,10 +61,10 @@ func TestTargetDelegationMetadata(t *testing.T) {
 
 	path := test.CreateTempDir(t, "", "tuf_temp")
 	tm, err := NewTufMirror(embed.DevRoot, path, server.URL+"/metadata", server.URL+"/targets")
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 
 	targets, err := tm.TufClient.LoadDelegatedTargets("test-role", "targets")
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.Greater(t, len(targets.Signed.Targets), 0)
 }
 
@@ -74,22 +74,22 @@ func TestGetDelegatedTargetMirrors(t *testing.T) {
 
 	path := test.CreateTempDir(t, "", "tuf_temp")
 	m, err := NewTufMirror(embed.DevRoot, path, server.URL+"/metadata", server.URL+"/targets")
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 
 	mirrors, err := m.GetDelegatedTargetMirrors()
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.Greater(t, len(mirrors), 0)
 
 	// check for index image annotations
 	for _, mirror := range mirrors {
 		idx := *mirror.Index
 		mf, err := idx.RawManifest()
-		assert.Nil(t, err)
+		assert.NoError(t, err)
 
 		// unmarshal manifest with annotations
 		l := &Layers{}
 		err = json.Unmarshal(mf, l)
-		assert.Nil(t, err)
+		assert.NoError(t, err)
 
 		// check that layers are annotated
 		for _, layer := range l.Layers {