Adding a failing test.

Co-authored-by: Brandon Teng <bteng22@github.com>
This commit is contained in:
Federico Builes
2024-03-27 15:04:38 +01:00
parent 5bbc3ba658
commit 0e665bf3ac
2 changed files with 18 additions and 3 deletions

View File

@@ -164,3 +164,14 @@ test('it adds packages outside of the deny lists', async () => {
expect(deniedChanges.length).toEqual(0)
})
test('it adds packages with versions', async () => {
const changes: Changes = [npmChange]
const deniedChanges = await getDeniedChanges(
changes,
['pkg:npm/reeuhq@1.0.4'],
['pkg:maven:org.apache.logging.log4j']
)
expect(deniedChanges.length).toEqual(0)
})

View File

@@ -11,11 +11,15 @@ export async function getDeniedChanges(
let failed = false
for (const change of changes) {
change.name = change.name.toLowerCase()
const packageUrl = change.package_url.toLowerCase().split('@')[0]
const [name, version] = change.package_url.toLowerCase().split('@')
if (deniedPackages) {
for (const denied of deniedPackages) {
if (packageUrl === denied.split('@')[0].toLowerCase()) {
const [dpName, dpVersion] = denied.toLowerCase().split('@')
if (name === dpName && version !== dpVersion) {
continue
}
if (name === dpName && version === dpVersion) {
changesDenied.push(change)
failed = true
}
@@ -24,7 +28,7 @@ export async function getDeniedChanges(
if (deniedGroups) {
for (const denied of deniedGroups) {
if (packageUrl.startsWith(denied.toLowerCase())) {
if (name.startsWith(denied.toLowerCase())) {
changesDenied.push(change)
failed = true
}