Merge pull request #116 from actions/unknown-licenses

Unknown licenses
This commit is contained in:
Federico Builes
2022-06-15 15:26:38 +02:00
committed by GitHub
4 changed files with 4 additions and 5 deletions

3
dist/index.js generated vendored
View File

@@ -86,7 +86,6 @@ function getDeniedLicenseChanges(changes, licenses) {
let unknown = [];
for (const change of changes) {
let license = change.license;
// TODO: be loud about unknown licenses
if (license === null) {
unknown.push(change);
continue;
@@ -191,9 +190,9 @@ function run() {
let [licenseErrors, unknownLicenses] = (0, licenses_1.getDeniedLicenseChanges)(changes, licenses);
if (licenseErrors.length > 0) {
printLicensesError(licenseErrors, licenses);
printNullLicenses(unknownLicenses);
core.setFailed('Dependency review detected incompatible licenses.');
}
printNullLicenses(unknownLicenses);
if (failed) {
core.setFailed('Dependency review detected vulnerable packages.');
}

2
dist/index.js.map generated vendored

File diff suppressed because one or more lines are too long

View File

@@ -26,7 +26,6 @@ export function getDeniedLicenseChanges(
for (const change of changes) {
let license = change.license
// TODO: be loud about unknown licenses
if (license === null) {
unknown.push(change)
continue

View File

@@ -59,10 +59,11 @@ async function run(): Promise<void> {
if (licenseErrors.length > 0) {
printLicensesError(licenseErrors, licenses)
printNullLicenses(unknownLicenses)
core.setFailed('Dependency review detected incompatible licenses.')
}
printNullLicenses(unknownLicenses)
if (failed) {
core.setFailed('Dependency review detected vulnerable packages.')
} else {