Merge pull request #396 from crazy-max/github-isghes

github: isGHES func

.github/buildx-lab-releases.json

@@ -40,6 +40,47 @@
       "https://github.com/docker/buildx-desktop/releases/download/v0.14.1-desktop.1/checksums.txt"
     ]
   },
+  "v0.15.1-desktop.1": {
+    "id": 161492089,
+    "tag_name": "v0.15.1-desktop.1",
+    "html_url": "https://github.com/docker/buildx-desktop/releases/tag/v0.15.1-desktop.1",
+    "assets": [
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.darwin-amd64",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.darwin-amd64.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.darwin-amd64.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.darwin-arm64",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.darwin-arm64.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.darwin-arm64.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-amd64",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-amd64.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-amd64.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-arm-v6",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-arm-v6.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-arm-v6.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-arm-v7",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-arm-v7.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-arm-v7.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-arm64",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-arm64.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-arm64.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-ppc64le",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-ppc64le.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-ppc64le.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-riscv64",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-riscv64.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-riscv64.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-s390x",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-s390x.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.linux-s390x.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.windows-amd64.exe",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.windows-amd64.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.windows-amd64.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.windows-arm64.exe",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.windows-arm64.provenance.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/buildx-v0.15.1-desktop.1.windows-arm64.sbom.json",
+      "https://github.com/docker/buildx-desktop/releases/download/v0.15.1-desktop.1/checksums.txt"
+    ]
+  },
   "v0.15.0-desktop.1": {
     "id": 160473592,
     "tag_name": "v0.15.0-desktop.1",

.github/docker-releases.json

@@ -1,8 +1,38 @@
 {
   "latest": {
-    "id": 159031384,
-    "tag_name": "v26.1.4",
-    "html_url": "https://github.com/moby/moby/releases/tag/v26.1.4",
+    "id": 163311279,
+    "tag_name": "v27.0.3",
+    "html_url": "https://github.com/moby/moby/releases/tag/v27.0.3",
+    "assets": []
+  },
+  "v27.0.3": {
+    "id": 163311279,
+    "tag_name": "v27.0.3",
+    "html_url": "https://github.com/moby/moby/releases/tag/v27.0.3",
+    "assets": []
+  },
+  "v27.0.2": {
+    "id": 162600493,
+    "tag_name": "v27.0.2",
+    "html_url": "https://github.com/moby/moby/releases/tag/v27.0.2",
+    "assets": []
+  },
+  "v27.0.1": {
+    "id": 162009909,
+    "tag_name": "v27.0.1",
+    "html_url": "https://github.com/moby/moby/releases/tag/v27.0.1",
+    "assets": []
+  },
+  "v27.0.1-rc.1": {
+    "id": 161457618,
+    "tag_name": "v27.0.1-rc.1",
+    "html_url": "https://github.com/moby/moby/releases/tag/v27.0.1-rc.1",
+    "assets": []
+  },
+  "v23.0.13": {
+    "id": 161533551,
+    "tag_name": "v23.0.13",
+    "html_url": "https://github.com/moby/moby/releases/tag/v23.0.13",
     "assets": []
   },
   "v27.0.0-rc.2": {

.github/workflows/test.yml

@@ -15,7 +15,8 @@ on:
 
 env:
   NODE_VERSION: "20"
-  BUILDX_VERSION: "v0.15.1"
+  BUILDX_VERSION: "https://github.com/docker/buildx.git#d8c9ebde1fdcf659f1fa3efa6ccc27a28b0f1564"  # https://github.com/docker/buildx/pull/2551
+  BUILDKIT_IMAGE: "moby/buildkit:v0.14.1"
 
 jobs:
   test:
@@ -138,6 +139,7 @@ jobs:
         uses: docker/setup-buildx-action@v3
         with:
           version: ${{ env.BUILDX_VERSION }}
+          driver-opts: image=${{ env.BUILDKIT_IMAGE }}
           use: false
       -
         name: Install

__tests__/buildkit/git.test.ts

@@ -0,0 +1,344 @@
+/**
+ * Copyright 2024 actions-toolkit authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {beforeEach, describe, expect, jest, test} from '@jest/globals';
+
+import {Git} from '../../src/buildkit/git';
+
+import {GitRef, GitURL} from '../../src/types/buildkit/git';
+
+beforeEach(() => {
+  jest.restoreAllMocks();
+});
+
+describe('parseURL', () => {
+  // prettier-ignore
+  test.each([
+    [
+      'http://github.com/moby/buildkit',
+      {
+        scheme: 'http',
+        host: 'github.com',
+        path: '/moby/buildkit'
+      } as GitURL,
+      false
+    ],
+    [
+      'https://github.com/moby/buildkit',
+      {
+        scheme: 'https',
+        host: 'github.com',
+        path: '/moby/buildkit'
+      } as GitURL,
+      false
+    ],
+    [
+      'http://github.com/moby/buildkit#v1.0.0',
+      {
+        scheme: 'http',
+        host: 'github.com',
+        path: '/moby/buildkit',
+        fragment: {
+          ref: 'v1.0.0',
+        }
+      } as GitURL,
+      false
+    ],
+    [
+      'http://github.com/moby/buildkit#v1.0.0:subdir',
+      {
+        scheme: 'http',
+        host: 'github.com',
+        path: '/moby/buildkit',
+        fragment: {
+          ref: 'v1.0.0',
+          subdir: 'subdir'
+        }
+      } as GitURL,
+      false
+    ],
+    [
+      'http://foo:bar@github.com/moby/buildkit#v1.0.0',
+      {
+        scheme: 'http',
+        host: 'github.com',
+        path: '/moby/buildkit',
+        fragment: {
+          ref: 'v1.0.0',
+        },
+        user: {
+          username: 'foo',
+          password: 'bar',
+          passwordSet: true
+        }
+      } as GitURL,
+      false
+    ],
+    [
+      'ssh://git@github.com/moby/buildkit.git',
+      {
+        scheme: 'ssh',
+        host: 'github.com',
+        path: '/moby/buildkit.git',
+        user: {
+          username: 'git',
+          password: '',
+          passwordSet: false
+        }
+      } as GitURL,
+      false
+    ],
+    [
+      'ssh://git@github.com:22/moby/buildkit.git',
+      {
+        scheme: 'ssh',
+        host: 'github.com:22',
+        path: '/moby/buildkit.git',
+        user: {
+          username: 'git',
+          password: '',
+          passwordSet: false
+        }
+      } as GitURL,
+      false
+    ],
+    // TODO: handle SCP-style URLs
+    // [
+    //   'git@github.com:moby/buildkit.git',
+    //   {
+    //     scheme: 'ssh',
+    //     host: 'github.com:22',
+    //     path: 'moby/buildkit.git',
+    //     user: {
+    //       username: 'git',
+    //       password: '',
+    //       passwordSet: false
+    //     }
+    //   } as GitURL,
+    //   false
+    // ],
+    [
+      'ssh://root@subdomain.example.hostname:2222/root/my/really/weird/path/foo.git',
+      {
+        scheme: 'ssh',
+        host: 'subdomain.example.hostname:2222',
+        path: '/root/my/really/weird/path/foo.git',
+        user: {
+          username: 'root',
+          password: '',
+          passwordSet: false
+        }
+      } as GitURL,
+      false
+    ],
+    [
+      'git://host.xz:1234/path/to/repo.git',
+      {
+        scheme: 'git',
+        host: 'host.xz:1234',
+        path: '/path/to/repo.git',
+      } as GitURL,
+      false
+    ],
+    [
+      'ssh://someuser@192.168.0.123:456/~/repo-in-my-home-dir.git',
+      {
+        scheme: 'ssh',
+        host: '192.168.0.123:456',
+        path: '/~/repo-in-my-home-dir.git',
+        user: {
+          username: 'someuser',
+          password: '',
+          passwordSet: false
+        }
+      } as GitURL,
+      false
+    ],
+    [
+      'httpx://github.com/moby/buildkit',
+      {} as GitURL,
+      true
+    ],
+    [
+      'HTTP://github.com/moby/buildkit',
+      {
+        scheme: 'http',
+        host: 'github.com',
+        path: '/moby/buildkit'
+      } as GitURL,
+      false
+    ],
+  ])('given %p', async (ref: string, expected: GitURL, expectedErr: boolean) => {
+    try {
+      const got = Git.parseURL(ref);
+      expect(got.scheme).toEqual(expected.scheme);
+      expect(got.host).toEqual(expected.host);
+      expect(got.path).toEqual(expected.path);
+      expect(got.fragment).toEqual(expected.fragment);
+      expect(got.user?.username).toEqual(expected.user?.username);
+      expect(got.user?.password).toEqual(expected.user?.password);
+      expect(got.user?.passwordSet).toEqual(expected.user?.passwordSet);
+    } catch (err) {
+      if (!expectedErr) {
+        console.log(err);
+      }
+      // eslint-disable-next-line jest/no-conditional-expect
+      expect(expectedErr).toBeTruthy();
+    }
+  });
+});
+
+describe('parseRef', () => {
+  // prettier-ignore
+  test.each([
+    [
+      'https://example.com/',
+      undefined
+    ],
+    [
+      'https://example.com/foo',
+      undefined
+    ],
+    [
+      'https://example.com/foo.git',
+      {
+        remote: 'https://example.com/foo.git',
+        shortName: 'foo'
+      } as GitRef
+    ],
+    [
+      'https://example.com/foo.git#deadbeef',
+      {
+        remote: 'https://example.com/foo.git',
+        shortName: 'foo',
+        commit: 'deadbeef'
+      } as GitRef
+    ],
+    [
+      'https://example.com/foo.git#release/1.2',
+      {
+        remote: 'https://example.com/foo.git',
+        shortName: 'foo',
+        commit: 'release/1.2'
+      } as GitRef
+    ],
+    [
+      'https://example.com/foo.git/',
+      undefined
+    ],
+    [
+      'https://example.com/foo.git.bar',
+      undefined
+    ],
+    [
+      'git://example.com/foo',
+      {
+        remote: 'git://example.com/foo',
+        shortName: 'foo',
+        unencryptedTCP: true
+      } as GitRef
+    ],
+    [
+      'github.com/moby/buildkit',
+      {
+        remote: 'github.com/moby/buildkit',
+        shortName: 'buildkit',
+        indistinguishableFromLocal: true
+      } as GitRef
+    ],
+    [
+      'custom.xyz/moby/buildkit.git',
+      undefined
+    ],
+    [
+      'https://github.com/moby/buildkit',
+      undefined
+    ],
+    [
+      'https://github.com/moby/buildkit.git',
+      {
+        remote: 'https://github.com/moby/buildkit.git',
+        shortName: 'buildkit',
+      } as GitRef
+    ],
+    [
+      'https://foo:bar@github.com/moby/buildkit.git',
+      {
+        remote: 'https://foo:bar@github.com/moby/buildkit.git',
+        shortName: 'buildkit',
+      } as GitRef
+    ],
+    // TODO handle SCP-style URLs
+    // [
+    //   'git@github.com:moby/buildkit',
+    //   {
+    //     remote: 'git@github.com:moby/buildkit',
+    //     shortName: 'buildkit',
+    //   } as GitRef
+    // ],
+    // [
+    //   'git@github.com:moby/buildkit.git',
+    //   {
+    //     remote: 'git@github.com:moby/buildkit',
+    //     shortName: 'buildkit',
+    //   } as GitRef
+    // ],
+    // [
+    //   'git@bitbucket.org:atlassianlabs/atlassian-docker.git',
+    //   {
+    //     remote: 'git@bitbucket.org:atlassianlabs/atlassian-docker.git',
+    //     shortName: 'atlassian-docker',
+    //   } as GitRef
+    // ],
+    [
+      'https://github.com/foo/bar.git#baz/qux:quux/quuz',
+      {
+        remote: 'https://github.com/foo/bar.git',
+        shortName: 'bar',
+        commit: 'baz/qux',
+        subDir: 'quux/quuz',
+      } as GitRef
+    ],
+    [
+      'https://github.com/docker/docker.git#:myfolder',
+      {
+        remote: 'https://github.com/docker/docker.git',
+        shortName: 'docker',
+        subDir: 'myfolder',
+        commit: ''
+      } as GitRef
+    ],
+    [
+      './.git',
+      undefined
+    ],
+    [
+      '.git',
+      undefined
+    ],
+  ])('given %p', async (ref: string, expected: GitRef | undefined) => {
+    try {
+      const got = Git.parseRef(ref);
+      expect(got).toEqual(expected);
+    } catch (err) {
+      if (expected) {
+        console.log(err);
+      }
+      // eslint-disable-next-line jest/no-conditional-expect
+      expect(expected).toBeUndefined();
+    }
+  });
+});

__tests__/buildx/bake.test.ts

@@ -23,13 +23,14 @@ import {Bake} from '../../src/buildx/bake';
 import {Context} from '../../src/context';
 
 import {ExecOptions} from '@actions/exec';
-import {BakeDefinition, BakeMetadata} from '../../src/types/buildx/bake';
+import {BakeDefinition} from '../../src/types/buildx/bake';
+import {BuildMetadata} from '../../src/types/buildx/build';
 
 const fixturesDir = path.join(__dirname, '..', 'fixtures');
 // prettier-ignore
 const tmpDir = path.join(process.env.TEMP || '/tmp', 'buildx-inputs-jest');
 const tmpName = path.join(tmpDir, '.tmpname-jest');
-const metadata: BakeMetadata = {
+const metadata: BuildMetadata = {
   app: {
     'buildx.build.ref': 'default/default/7frbdw1fmfozgtqavghowsepk'
   },
@@ -57,7 +58,7 @@ describe('resolveMetadata', () => {
   it('matches', async () => {
     const bake = new Bake();
     fs.writeFileSync(bake.getMetadataFilePath(), JSON.stringify(metadata));
-    expect(bake.resolveMetadata()).toEqual(metadata as BakeMetadata);
+    expect(bake.resolveMetadata()).toEqual(metadata as BuildMetadata);
   });
 });
 

__tests__/buildx/build.test.ts

@@ -80,6 +80,16 @@ describe('resolveProvenance', () => {
   });
 });
 
+describe('resolveWarnings', () => {
+  it('matches', async () => {
+    const build = new Build();
+    fs.writeFileSync(build.getMetadataFilePath(), JSON.stringify(metadata));
+    const warnings = build.resolveWarnings();
+    expect(warnings).toBeDefined();
+    expect(warnings?.length).toEqual(3);
+  });
+});
+
 describe('resolveDigest', () => {
   it('matches', async () => {
     const build = new Build();

__tests__/fixtures/lint.Dockerfile

@@ -0,0 +1,28 @@
+# syntax=docker/dockerfile-upstream:master
+
+# Copyright 2024 actions-toolkit authors
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+frOM busybox as base
+cOpy lint.Dockerfile .
+
+from scratch
+MAINTAINER moby@example.com
+COPy --from=base \
+  /lint.Dockerfile \
+  /
+
+CMD [ "echo", "Hello, Norway!" ]
+CMD [ "echo", "Hello, Sweden!" ]
+ENTRYPOINT my-program start

__tests__/fixtures/metadata.json

@@ -40,6 +40,189 @@
     }
   },
   "buildx.build.ref": "default/default/n6ibcp9b2pw108rrz7ywdznvo",
+  "buildx.build.warnings": [
+    {
+      "vertex": "sha256:7b477ac5dd3a4c4d2523f7f7f20406b626395de082f44fd5ff996323ec8257d0",
+      "level": 1,
+      "short": "Q29uc2lzdGVudEluc3RydWN0aW9uQ2FzaW5nOiBDb21tYW5kICdmck9NJyBzaG91bGQgYmUgY29uc2lzdGVudGx5IGNhc2VkIChsaW5lIDIp",
+      "detail": [
+        "SW5zdHJ1Y3Rpb25zIHNob3VsZCBiZSBpbiBjb25zaXN0ZW50IGNhc2luZyAoYWxsIGxvd2VyIG9yIGFsbCB1cHBlcik="
+      ],
+      "url": "https://docs.docker.com/go/dockerfile/rule/consistent-instruction-casing/",
+      "sourceInfo": {
+        "filename": "Dockerfile",
+        "data": "IyBzeW50YXg9ZG9ja2VyL2RvY2tlcmZpbGUtdXBzdHJlYW06bWFzdGVyCmZyT00gYnVzeWJveCBhcyBiYXNlCmNPcHkgRG9ja2VyZmlsZSAuCgpmcm9tIHNjcmF0Y2gKQ09QeSAtLWZyb209YmFzZSBcCiAgL0RvY2tlcmZpbGUgXAogIC8K",
+        "definition": {
+          "def": [
+            "GsUBChJsb2NhbDovL2RvY2tlcmZpbGUSFAoMbG9jYWwuZGlmZmVyEgRub25lEkoKEWxvY2FsLmZvbGxvd3BhdGhzEjVbIkRvY2tlcmZpbGUiLCJEb2NrZXJmaWxlLmRvY2tlcmlnbm9yZSIsImRvY2tlcmZpbGUiXRIqCg1sb2NhbC5zZXNzaW9uEhkwN3A3MzJ6aGR4NXV1NnVsZDNzOGpteWo2EiEKE2xvY2FsLnNoYXJlZGtleWhpbnQSCmRvY2tlcmZpbGVaAA==",
+            "CkkKR3NoYTI1Njo3YjQ3N2FjNWRkM2E0YzRkMjUyM2Y3ZjdmMjA0MDZiNjI2Mzk1ZGUwODJmNDRmZDVmZjk5NjMyM2VjODI1N2Qw"
+          ],
+          "metadata": {
+            "sha256:7b477ac5dd3a4c4d2523f7f7f20406b626395de082f44fd5ff996323ec8257d0": {
+              "description": {
+                "llb.customname": "[internal] load build definition from Dockerfile"
+              },
+              "caps": {
+                "source.local": true,
+                "source.local.followpaths": true,
+                "source.local.sessionid": true,
+                "source.local.sharedkeyhint": true
+              }
+            },
+            "sha256:a06279dbe062a3b181c9b918abfaf37ca8106f1f9745b9d42356b3195b205cd1": {
+              "caps": {
+                "constraints": true,
+                "meta.description": true,
+                "platform": true
+              }
+            }
+          },
+          "Source": {
+            "locations": {
+              "sha256:7b477ac5dd3a4c4d2523f7f7f20406b626395de082f44fd5ff996323ec8257d0": {}
+            }
+          }
+        },
+        "language": "Dockerfile"
+      },
+      "range": [
+        {
+          "start": {
+            "line": 2
+          },
+          "end": {
+            "line": 2
+          }
+        }
+      ]
+    },
+    {
+      "vertex": "sha256:7b477ac5dd3a4c4d2523f7f7f20406b626395de082f44fd5ff996323ec8257d0",
+      "level": 1,
+      "short": "Q29uc2lzdGVudEluc3RydWN0aW9uQ2FzaW5nOiBDb21tYW5kICdjT3B5JyBzaG91bGQgYmUgY29uc2lzdGVudGx5IGNhc2VkIChsaW5lIDMp",
+      "detail": [
+        "SW5zdHJ1Y3Rpb25zIHNob3VsZCBiZSBpbiBjb25zaXN0ZW50IGNhc2luZyAoYWxsIGxvd2VyIG9yIGFsbCB1cHBlcik="
+      ],
+      "url": "https://docs.docker.com/go/dockerfile/rule/consistent-instruction-casing/",
+      "sourceInfo": {
+        "filename": "Dockerfile",
+        "data": "IyBzeW50YXg9ZG9ja2VyL2RvY2tlcmZpbGUtdXBzdHJlYW06bWFzdGVyCmZyT00gYnVzeWJveCBhcyBiYXNlCmNPcHkgRG9ja2VyZmlsZSAuCgpmcm9tIHNjcmF0Y2gKQ09QeSAtLWZyb209YmFzZSBcCiAgL0RvY2tlcmZpbGUgXAogIC8K",
+        "definition": {
+          "def": [
+            "GsUBChJsb2NhbDovL2RvY2tlcmZpbGUSFAoMbG9jYWwuZGlmZmVyEgRub25lEkoKEWxvY2FsLmZvbGxvd3BhdGhzEjVbIkRvY2tlcmZpbGUiLCJEb2NrZXJmaWxlLmRvY2tlcmlnbm9yZSIsImRvY2tlcmZpbGUiXRIqCg1sb2NhbC5zZXNzaW9uEhkwN3A3MzJ6aGR4NXV1NnVsZDNzOGpteWo2EiEKE2xvY2FsLnNoYXJlZGtleWhpbnQSCmRvY2tlcmZpbGVaAA==",
+            "CkkKR3NoYTI1Njo3YjQ3N2FjNWRkM2E0YzRkMjUyM2Y3ZjdmMjA0MDZiNjI2Mzk1ZGUwODJmNDRmZDVmZjk5NjMyM2VjODI1N2Qw"
+          ],
+          "metadata": {
+            "sha256:7b477ac5dd3a4c4d2523f7f7f20406b626395de082f44fd5ff996323ec8257d0": {
+              "description": {
+                "llb.customname": "[internal] load build definition from Dockerfile"
+              },
+              "caps": {
+                "source.local": true,
+                "source.local.followpaths": true,
+                "source.local.sessionid": true,
+                "source.local.sharedkeyhint": true
+              }
+            },
+            "sha256:a06279dbe062a3b181c9b918abfaf37ca8106f1f9745b9d42356b3195b205cd1": {
+              "caps": {
+                "constraints": true,
+                "meta.description": true,
+                "platform": true
+              }
+            }
+          },
+          "Source": {
+            "locations": {
+              "sha256:7b477ac5dd3a4c4d2523f7f7f20406b626395de082f44fd5ff996323ec8257d0": {}
+            }
+          }
+        },
+        "language": "Dockerfile"
+      },
+      "range": [
+        {
+          "start": {
+            "line": 3
+          },
+          "end": {
+            "line": 3
+          }
+        }
+      ]
+    },
+    {
+      "vertex": "sha256:7b477ac5dd3a4c4d2523f7f7f20406b626395de082f44fd5ff996323ec8257d0",
+      "level": 1,
+      "short": "Q29uc2lzdGVudEluc3RydWN0aW9uQ2FzaW5nOiBDb21tYW5kICdDT1B5JyBzaG91bGQgYmUgY29uc2lzdGVudGx5IGNhc2VkIChsaW5lIDYp",
+      "detail": [
+        "SW5zdHJ1Y3Rpb25zIHNob3VsZCBiZSBpbiBjb25zaXN0ZW50IGNhc2luZyAoYWxsIGxvd2VyIG9yIGFsbCB1cHBlcik="
+      ],
+      "url": "https://docs.docker.com/go/dockerfile/rule/consistent-instruction-casing/",
+      "sourceInfo": {
+        "filename": "Dockerfile",
+        "data": "IyBzeW50YXg9ZG9ja2VyL2RvY2tlcmZpbGUtdXBzdHJlYW06bWFzdGVyCmZyT00gYnVzeWJveCBhcyBiYXNlCmNPcHkgRG9ja2VyZmlsZSAuCgpmcm9tIHNjcmF0Y2gKQ09QeSAtLWZyb209YmFzZSBcCiAgL0RvY2tlcmZpbGUgXAogIC8K",
+        "definition": {
+          "def": [
+            "GsUBChJsb2NhbDovL2RvY2tlcmZpbGUSFAoMbG9jYWwuZGlmZmVyEgRub25lEkoKEWxvY2FsLmZvbGxvd3BhdGhzEjVbIkRvY2tlcmZpbGUiLCJEb2NrZXJmaWxlLmRvY2tlcmlnbm9yZSIsImRvY2tlcmZpbGUiXRIqCg1sb2NhbC5zZXNzaW9uEhkwN3A3MzJ6aGR4NXV1NnVsZDNzOGpteWo2EiEKE2xvY2FsLnNoYXJlZGtleWhpbnQSCmRvY2tlcmZpbGVaAA==",
+            "CkkKR3NoYTI1Njo3YjQ3N2FjNWRkM2E0YzRkMjUyM2Y3ZjdmMjA0MDZiNjI2Mzk1ZGUwODJmNDRmZDVmZjk5NjMyM2VjODI1N2Qw"
+          ],
+          "metadata": {
+            "sha256:7b477ac5dd3a4c4d2523f7f7f20406b626395de082f44fd5ff996323ec8257d0": {
+              "description": {
+                "llb.customname": "[internal] load build definition from Dockerfile"
+              },
+              "caps": {
+                "source.local": true,
+                "source.local.followpaths": true,
+                "source.local.sessionid": true,
+                "source.local.sharedkeyhint": true
+              }
+            },
+            "sha256:a06279dbe062a3b181c9b918abfaf37ca8106f1f9745b9d42356b3195b205cd1": {
+              "caps": {
+                "constraints": true,
+                "meta.description": true,
+                "platform": true
+              }
+            }
+          },
+          "Source": {
+            "locations": {
+              "sha256:7b477ac5dd3a4c4d2523f7f7f20406b626395de082f44fd5ff996323ec8257d0": {}
+            }
+          }
+        },
+        "language": "Dockerfile"
+      },
+      "range": [
+        {
+          "start": {
+            "line": 6
+          },
+          "end": {
+            "line": 6
+          }
+        },
+        {
+          "start": {
+            "line": 7
+          },
+          "end": {
+            "line": 7
+          }
+        },
+        {
+          "start": {
+            "line": 8
+          },
+          "end": {
+            "line": 8
+          }
+        }
+      ]
+    }
+  ],
   "containerimage.config.digest": "sha256:059b68a595b22564a1cbc167f369349fdc2ecc1f7bc092c2235cbf601a795fd",
   "containerimage.digest": "sha256:b09b9482c72371486bb2c1d2c2a2633ed1d0b8389e12c8d52b9e052725c0c83c"
 }

__tests__/github.test.itg.ts

@@ -249,3 +249,40 @@ maybe('writeBuildSummary', () => {
     });
   });
 });
+
+maybe('annotateBuildWarnings', () => {
+  it('annoate lint issues', async () => {
+    const buildx = new Buildx();
+    const build = new Build({buildx: buildx});
+
+    fs.mkdirSync(tmpDir, {recursive: true});
+    await expect(
+      (async () => {
+        // prettier-ignore
+        const buildCmd = await buildx.getCommand([
+          '--builder', process.env.CTN_BUILDER_NAME ?? 'default',
+          'build',
+          '-f', path.join(fixturesDir, 'lint.Dockerfile'),
+          fixturesDir,
+          '--metadata-file', build.getMetadataFilePath()
+        ]);
+        await Exec.exec(buildCmd.command, buildCmd.args, {
+          env: Object.assign({}, process.env, {
+            BUILDX_METADATA_WARNINGS: 'true'
+          }) as {
+            [key: string]: string;
+          }
+        });
+      })()
+    ).resolves.not.toThrow();
+
+    const metadata = build.resolveMetadata();
+    expect(metadata).toBeDefined();
+    const buildRef = build.resolveRef(metadata);
+    expect(buildRef).toBeDefined();
+    const buildWarnings = build.resolveWarnings(metadata);
+    expect(buildWarnings).toBeDefined();
+
+    await GitHub.annotateBuildWarnings(path.join(fixturesDir, 'lint.Dockerfile'), buildWarnings);
+  });
+});

__tests__/github.test.ts

@@ -85,6 +85,28 @@ describe('apiURL', () => {
   });
 });
 
+describe('isGHES', () => {
+  afterEach(() => {
+    process.env.GITHUB_SERVER_URL = '';
+  });
+  it('should return false when the request domain is github.com', () => {
+    process.env.GITHUB_SERVER_URL = 'https://github.com';
+    expect(GitHub.isGHES).toBe(false);
+  });
+  it('should return false when the request domain ends with ghe.com', () => {
+    process.env.GITHUB_SERVER_URL = 'https://my.domain.ghe.com';
+    expect(GitHub.isGHES).toBe(false);
+  });
+  it('should return false when the request domain ends with ghe.localhost', () => {
+    process.env.GITHUB_SERVER_URL = 'https://my.domain.ghe.localhost';
+    expect(GitHub.isGHES).toBe(false);
+  });
+  it('should return true when the request domain is specific to an enterprise', () => {
+    process.env.GITHUB_SERVER_URL = 'https://my-enterprise.github.com';
+    expect(GitHub.isGHES).toBe(true);
+  });
+});
+
 describe('repository', () => {
   it('returns GitHub repository', async () => {
     expect(GitHub.repository).toEqual('docker/actions-toolkit');

src/buildkit/git.ts

@@ -0,0 +1,113 @@
+/**
+ * Copyright 2024 actions-toolkit authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {GitRef, GitURL, GitURLFragment, URLUserInfo} from '../types/buildkit/git';
+
+export class Git {
+  private static protoRegexp = new RegExp('^[a-zA-Z0-9]+://');
+  private static supportedProtos = {
+    http: {},
+    https: {},
+    ssh: {},
+    git: {}
+  };
+
+  // https://github.com/moby/buildkit/blob/2ec1338fc13f73b43f0b1b4f4678d7cd654bc86c/util/gitutil/git_url.go#L79
+  public static parseURL(remote: string): GitURL {
+    const match = remote.match(Git.protoRegexp);
+    if (match && match.length > 0) {
+      let proto = match[0].toLowerCase();
+      proto = proto.slice(0, proto.lastIndexOf('://'));
+      if (!(proto in Git.supportedProtos)) {
+        throw new Error(`Invalid protocol: ${proto}`);
+      }
+      return Git.fromURL(new URL(remote));
+    }
+
+    throw new Error('Unknown protocol');
+  }
+
+  // https://github.com/moby/buildkit/blob/2ec1338fc13f73b43f0b1b4f4678d7cd654bc86c/util/gitutil/git_url.go#L108
+  private static fromURL(url: URL): GitURL {
+    const withoutFragment = new URL(url.toString());
+    withoutFragment.hash = '';
+
+    let user: URLUserInfo | undefined;
+    if (url.username || url.password) {
+      user = {
+        username: url.username,
+        password: url.password,
+        passwordSet: url.password !== ''
+      };
+    }
+
+    // TODO: handle SCP-style URLs
+
+    return {
+      scheme: url.protocol.slice(0, -1),
+      user: user,
+      host: `${url.hostname}${url.port ? ':' + url.port : ''}`,
+      path: url.pathname,
+      fragment: Git.splitGitFragment(url.hash),
+      remote: withoutFragment.toString()
+    };
+  }
+
+  // https://github.com/moby/buildkit/blob/2ec1338fc13f73b43f0b1b4f4678d7cd654bc86c/util/gitutil/git_url.go#L69
+  private static splitGitFragment(fragment: string): GitURLFragment | undefined {
+    if (fragment === '') {
+      return undefined;
+    }
+    const [ref, subdir] = fragment.slice(1).split(':');
+    return {
+      ref: ref,
+      subdir: subdir
+    };
+  }
+
+  // https://github.com/moby/buildkit/blob/2ec1338fc13f73b43f0b1b4f4678d7cd654bc86c/util/gitutil/git_ref.go#L52
+  public static parseRef(ref: string): GitRef | undefined {
+    const res: GitRef = {};
+    let remote: GitURL;
+    if (ref.startsWith('./') || ref.startsWith('../')) {
+      throw new Error('Invalid argument');
+    } else if (ref.startsWith('github.com/')) {
+      res.indistinguishableFromLocal = true; // Deprecated
+      remote = Git.fromURL(new URL('https://' + ref));
+    } else {
+      remote = Git.parseURL(ref);
+      if (['http', 'git'].includes(remote.scheme)) {
+        res.unencryptedTCP = true; // Discouraged, but not deprecated
+      }
+      if (['http', 'https'].includes(remote.scheme) && !remote.path.endsWith('.git')) {
+        throw new Error('Invalid argument');
+      }
+    }
+    res.remote = remote.remote;
+
+    if (res.indistinguishableFromLocal) {
+      res.remote = res.remote.split('://')[1];
+    }
+    if (remote.fragment) {
+      res.commit = remote.fragment.ref;
+      res.subDir = remote.fragment.subdir;
+    }
+
+    const repoSplitBySlash = res.remote.split('/');
+    res.shortName = repoSplitBySlash[repoSplitBySlash.length - 1].replace('.git', '');
+    return res;
+  }
+}

src/buildx/bake.ts

@@ -24,7 +24,8 @@ import {Exec} from '../exec';
 import {Util} from '../util';
 
 import {ExecOptions} from '@actions/exec';
-import {BakeDefinition, BakeMetadata} from '../types/buildx/bake';
+import {BakeDefinition} from '../types/buildx/bake';
+import {BuildMetadata} from '../types/buildx/build';
 
 export interface BakeOpts {
   buildx?: Buildx;
@@ -57,7 +58,7 @@ export class Bake {
     return path.join(Context.tmpDir(), this.metadataFilename);
   }
 
-  public resolveMetadata(): BakeMetadata | undefined {
+  public resolveMetadata(): BuildMetadata | undefined {
     const metadataFile = this.getMetadataFilePath();
     if (!fs.existsSync(metadataFile)) {
       return undefined;
@@ -66,10 +67,10 @@ export class Bake {
     if (content === 'null') {
       return undefined;
     }
-    return <BakeMetadata>JSON.parse(content);
+    return <BuildMetadata>JSON.parse(content);
   }
 
-  public resolveRefs(metadata?: BakeMetadata): Array<string> | undefined {
+  public resolveRefs(metadata?: BuildMetadata): Array<string> | undefined {
     if (!metadata) {
       metadata = this.resolveMetadata();
       if (!metadata) {
@@ -82,7 +83,7 @@ export class Bake {
         refs.push(metadata[key]['buildx.build.ref']);
       }
     }
-    return refs;
+    return refs.length > 0 ? refs : undefined;
   }
 
   public async getDefinition(cmdOpts: BakeCmdOpts, execOptions?: ExecOptions): Promise<BakeDefinition> {

src/buildx/build.ts

@@ -25,6 +25,7 @@ import {GitHub} from '../github';
 import {Util} from '../util';
 
 import {BuildMetadata} from '../types/buildx/build';
+import {VertexWarning} from '../types/buildkit/client';
 import {ProvenancePredicate} from '../types/intoto/slsa_provenance/v0.2/provenance';
 
 export interface BuildOpts {
@@ -96,6 +97,19 @@ export class Build {
     return undefined;
   }
 
+  public resolveWarnings(metadata?: BuildMetadata): Array<VertexWarning> | undefined {
+    if (!metadata) {
+      metadata = this.resolveMetadata();
+      if (!metadata) {
+        return undefined;
+      }
+    }
+    if ('buildx.build.warnings' in metadata) {
+      return metadata['buildx.build.warnings'] as Array<VertexWarning>;
+    }
+    return undefined;
+  }
+
   public resolveDigest(metadata?: BuildMetadata): string | undefined {
     if (!metadata) {
       metadata = this.resolveMetadata();

src/github.ts

@@ -36,6 +36,7 @@ import {jwtDecode, JwtPayload} from 'jwt-decode';
 
 import {Util} from './util';
 
+import {VertexWarning} from './types/buildkit/client';
 import {BuildSummaryOpts, GitHubActionsRuntimeToken, GitHubActionsRuntimeTokenAC, GitHubRepo, UploadArtifactOpts, UploadArtifactResponse} from './types/github';
 
 export interface GitHubOpts {
@@ -65,6 +66,14 @@ export class GitHub {
     return process.env.GITHUB_API_URL || 'https://api.github.com';
   }
 
+  static get isGHES(): boolean {
+    const serverURL = new URL(GitHub.serverURL);
+    const hostname = serverURL.hostname.trimEnd().toUpperCase();
+    const isGitHubHost = hostname === 'GITHUB.COM';
+    const isGHESHost = hostname.endsWith('.GHE.COM') || hostname.endsWith('.GHE.LOCALHOST');
+    return !isGitHubHost && !isGHESHost;
+  }
+
   static get repository(): string {
     return `${github.context.repo.owner}/${github.context.repo.repo}`;
   }
@@ -122,6 +131,10 @@ export class GitHub {
   }
 
   public static async uploadArtifact(opts: UploadArtifactOpts): Promise<UploadArtifactResponse> {
+    if (GitHub.isGHES) {
+      throw new Error('@actions/artifact v2.0.0+ is currently not supported on GHES.');
+    }
+
     const artifactName = path.basename(opts.filename);
     const backendIds = getBackendIdsFromToken();
     const artifactClient = internalArtifactTwirpClient();
@@ -235,12 +248,10 @@ export class GitHub {
         .addRaw(`For a detailed look at the build, download the following build record archive and import it into Docker Desktop's Builds view. `)
         .addBreak()
         .addRaw(`Build records include details such as timing, dependencies, results, logs, traces, and other information about a build. `)
-        .addRaw(addLink('Learn more', 'https://docs.docker.com/go/build-summary/'))
+        .addRaw(addLink('Learn more', 'https://www.docker.com/blog/new-beta-feature-deep-dive-into-github-actions-docker-builds-with-docker-desktop/?utm_source=github&utm_medium=actions'))
       .addRaw('</p>')
       .addRaw(`<p>`)
-        .addRaw(`:arrow_down: ${addLink(`<strong>${Util.stringToUnicodeEntities(opts.uploadRes.filename)}</strong>`, artifactRelativeURL)} (${Util.formatFileSize(opts.uploadRes.size)})`)
-        .addBreak()
-        .addRaw(`This file includes <strong>${refsSize} build record${refsSize > 1 ? 's' : ''}</strong>.`)
+        .addRaw(`:arrow_down: ${addLink(`<strong>${Util.stringToUnicodeEntities(opts.uploadRes.filename)}</strong>`, artifactRelativeURL)} (${Util.formatFileSize(opts.uploadRes.size)} - includes <strong>${refsSize} build record${refsSize > 1 ? 's' : ''}</strong>)`)
       .addRaw(`</p>`)
       .addRaw(`<p>`)
         .addRaw(`Find this useful? `)
@@ -248,7 +259,7 @@ export class GitHub {
       .addRaw('</p>');
 
     // Preview
-    sum.addRaw(`<strong>Preview</strong>`).addBreak().addRaw('<p>');
+    sum.addRaw('<p>');
     const summaryTableData: Array<Array<SummaryTableCell>> = [
       [
         {header: true, data: 'ID'},
@@ -323,4 +334,39 @@ export class GitHub {
     core.info(`Writing summary`);
     await sum.addSeparator().write();
   }
+
+  public static async annotateBuildWarnings(source: string, warnings?: Array<VertexWarning>): Promise<void> {
+    (warnings ?? []).forEach(warning => {
+      if (!warning.detail || !warning.short) {
+        return;
+      }
+      const title = warning.detail.map(encoded => atob(encoded)).join(' ');
+      let message = atob(warning.short).replace(/\s\(line \d+\)$/, '');
+      if (warning.url) {
+        // https://github.com/docker/buildx/blob/d8c9ebde1fdcf659f1fa3efa6ccc27a28b0f1564/commands/build.go#L854
+        message += `\nMore info: ${warning.url}`;
+      }
+
+      // GitHub annotations don't clearly show ranges of lines, so we'll just
+      // show the first line
+      const startLine = warning.range && warning.range.length > 0 ? warning.range[0]?.start.line : undefined;
+
+      // TODO: When GitHub annotations support showing ranges properly, we can use this code
+      // let startLine: number | undefined, endLine: number | undefined;
+      // for (const range of warning.range ?? []) {
+      //   if (range.start.line && (!startLine || range.start.line < startLine)) {
+      //     startLine = range.start.line;
+      //   }
+      //   if (range.end.line && (!endLine || range.end.line > endLine)) {
+      //     endLine = range.end.line;
+      //   }
+      // }
+
+      core.warning(message, {
+        title: title,
+        file: source,
+        startLine: startLine
+      });
+    });
+  }
 }

src/types/buildkit/git.ts

@@ -0,0 +1,44 @@
+/**
+ * Copyright 2024 actions-toolkit authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+export interface GitURL {
+  scheme: string;
+  host: string;
+  path: string;
+  user?: URLUserInfo;
+  fragment?: GitURLFragment;
+  remote: string;
+}
+
+export interface GitURLFragment {
+  ref: string;
+  subdir: string;
+}
+
+export interface GitRef {
+  remote?: string;
+  shortName?: string;
+  commit?: string;
+  subDir?: string;
+  indistinguishableFromLocal?: boolean;
+  unencryptedTCP?: boolean;
+}
+
+export interface URLUserInfo {
+  username: string;
+  password: string;
+  passwordSet: boolean;
+}

src/types/buildx/bake.ts

@@ -19,10 +19,6 @@ export interface BakeDefinition {
   target: Record<string, Target>;
 }
 
-export interface BakeMetadata {
-  [target: string]: Record<string, string>;
-}
-
 export interface Group {
   targets: Array<string>;
 }