Merge pull request #1006 from crazy-max/rm-field-history

buildx(history): require buildx >=0.23.0 to export a build record

__tests__/util.test.ts

@@ -87,6 +87,12 @@ describe('getInputList', () => {
     expect(res).toEqual(['foo=bar', 'bar=qux']);
   });
 
+  it('multiline with comment and no infix comment', async () => {
+    setInput('labels', '# ignore this\nfoo=bar\nbar=qux#baz');
+    const res = Util.getInputList('labels', {comment: '#', commentNoInfix: true});
+    expect(res).toEqual(['foo=bar', 'bar=qux#baz']);
+  });
+
   it('different new lines and ignoring comma correctly', async () => {
     setInput('cache-from', 'user/app:cache\r\ntype=local,src=path/to/dir');
     const res = Util.getInputList('cache-from', {ignoreComma: true});

src/buildx/history.ts

@@ -70,6 +70,10 @@ export class History {
   }
 
   public async export(opts: ExportOpts): Promise<ExportResponse> {
+    if (!(await this.buildx.versionSatisfies('>=0.23.0'))) {
+      throw new Error('Buildx >= 0.23.0 is required to export a build record');
+    }
+
     let builderName: string = '';
     let nodeName: string = '';
     const refs: Array<string> = [];

src/types/buildx/history.ts

@@ -107,7 +107,6 @@ export interface ExportOpts {
   refs: Array<string>;
   noSummaries?: boolean;
   image?: string;
-  useContainer?: boolean;
 }
 
 export interface ExportResponse {

src/util.ts

@@ -24,6 +24,7 @@ import {parse} from 'csv-parse/sync';
 export interface ListOpts {
   ignoreComma?: boolean;
   comment?: string;
+  commentNoInfix?: boolean;
   quote?: string | boolean | Buffer | null;
 }
 
@@ -42,6 +43,7 @@ export class Util {
       columns: false,
       relaxQuotes: true,
       comment: opts?.comment,
+      comment_no_infix: opts?.commentNoInfix,
       relaxColumnCount: true,
       skipEmptyLines: true,
       quote: opts?.quote